You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This works around the incomplete reset in emu.factoryReset() by a full re-init for every test run.
I have poked around in the emulator itself, but could not get it working correctly. This is a bit slower than it was, but at least the Uncaught SyntaxError: Got [ERASED] expected EOF errors seem to be gone for now. I think it is somehow related to the internal state of Storage that does not get fully reset on factory reset.
This is essentially a workaround like #4160 . It is a bit less complex by just doing a complete new initialization of the whole emulator instead of adding logic for waiting for finished commands. I think that should be fixed in the emulators reset methods to prevent internal state surviving.
For now I have removed the testindex stuff from this PR to make this easy to revert when the emulator has been fixed. At least it gets the CI tests working again.
Yes - I guess ideally we'd fix factoryReset. I think the issue is that while sending "reset()" the emulator is still running the old code while characters are sent and interpreted, right until the point the command is run. I think ideally we'd export the jswrap_interface_reset function from the emulator, but until then if this solution works then great - after all it's just for tests so it's not goingto effect the end user
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works around the incomplete reset in
emu.factoryReset()by a full re-init for every test run.I have poked around in the emulator itself, but could not get it working correctly. This is a bit slower than it was, but at least the
Uncaught SyntaxError: Got [ERASED] expected EOFerrors seem to be gone for now. I think it is somehow related to the internal state ofStoragethat does not get fully reset on factory reset.The tests do not run in this repo because no apps changed, but you can have a look at the actions output here: https://github.com/halemmerich/BangleApps/actions/runs/27714695139/job/81984461701